RFR: 6832: Should allow plotting line charts for all quantities [v2]

Aymane Harmaz aharmaz at openjdk.org
Mon Feb 2 18:35:50 UTC 2026


On Mon, 2 Feb 2026 15:21:42 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Aymane Harmaz has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - update copyright year in AttributeComponentConfiguration
>>  - implemented merge sorting of items from multiple chunks
>>  - 6832: Should allow plotting line charts for all quantities
>
> core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/collection/PeekingIterator.java line 55:
> 
>> 53: 		if (!this.hasPeeked) {
>> 54: 			this.hasPeeked = true;
>> 55: 			this.peekedElement = this.sourceIterator.next();
> 
> Should there be a hasNext() check here?

Yes, thanks for pointing that out, I have added the check in both `peek()` and `next()`

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/688#discussion_r2755715422


More information about the jmc-dev mailing list