RFR: 5561: Support for Crypto Events in JMC [v4]

[Suchita Chaturvedi]

On Mon, 2 Feb 2026 13:25:49 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing spotless failure
>
> core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/security/CryptoUtil.java line 111:
> 
>> 109: 	}
>> 110: 
>> 111: 	public static String getCryptoIcon(
> 
> Splitting up the determination of the severity level and then deciding at the icon at the end might be cleaner. Perhaps using an enum for the severity level.

Icon is just a string here which will be used later to show the specific icon.

> core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/security/CryptoUtil.java line 168:
> 
>> 166: 	}
>> 167: 
>> 168: 	public static String getCryptoRuleResult(
> 
> There is a lot of code duplication. How about separating out some of the key functionality, e.g. :
> 
>   private static boolean isWeakSignatureAlgorithm(String signatureAlgorithm) {                                                                                           
>       return signatureAlgorithm.contains("MD2") || signatureAlgorithm.contains("MD5");                                                                                   
>   }

Both MD2 and MD5 have different logics of handling. Hence, i don't think we can merge them together.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/686#discussion_r2761172176
PR Review Comment: https://git.openjdk.org/jmc/pull/686#discussion_r2761177352