RFR: CODETOOLS-7902830: dtraceasm: do not Process.destroy the dtrace process [v3]

[Henri Tremblay]

On Tue, 23 Feb 2021 11:05:04 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Look here:
>>  https://mail.openjdk.java.net/pipermail/jmh-dev/2021-February/003134.html
>> 
>> Process.destroy closes the streams, so whatever output the profiler had accrued would be lost.
>> 
>> I need someone with functioning Mac OS dtrace to test this.
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Comment updates

jmh-core/src/test/java/org/openjdk/jmh/util/TestUtil.java line 37:

> 35:     @Test
> 36:     public void testPID_Current() {
> 37:         Assert.assertNotSame(0, Utils.getPid());

This should be an assertNotEquals no? Because assertNotSame will box the 0 and will probably always be not same no? Or an hardcoded 0 is always the same?

-------------

PR: https://git.openjdk.java.net/jmh/pull/22