RFR: CODETOOLS-7902830: dtraceasm: do not Process.destroy the dtrace process [v3]

Aleksey Shipilev shade at openjdk.java.net
Tue Feb 23 17:56:01 UTC 2021


On Tue, 23 Feb 2021 14:32:21 GMT, Henri Tremblay <github.com+1216819+henri-tremblay at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Comment updates
>
> jmh-core/src/test/java/org/openjdk/jmh/util/TestUtil.java line 37:
> 
>> 35:     @Test
>> 36:     public void testPID_Current() {
>> 37:         Assert.assertNotSame(0, Utils.getPid());
> 
> This should be an assertNotEquals no? Because assertNotSame will box the 0 and will probably always be not same no? Or an hardcoded 0 is always the same?

Right. Back to `assertTrue`, as current JUnit version does not have `assertThat`, and there is no `assertNotEquals`.

-------------

PR: https://git.openjdk.java.net/jmh/pull/22


More information about the jmh-dev mailing list