RFR: CODETOOLS-7902830: dtraceasm: do not Process.destroy the dtrace process [v3]

Paul Sandoz psandoz at openjdk.java.net
Tue Feb 23 16:48:48 UTC 2021


On Tue, 23 Feb 2021 11:05:04 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Look here:
>>  https://mail.openjdk.java.net/pipermail/jmh-dev/2021-February/003134.html
>> 
>> Process.destroy closes the streams, so whatever output the profiler had accrued would be lost.
>> 
>> I need someone with functioning Mac OS dtrace to test this.
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Comment updates

Looks good. I tested with a recent 17 build.

-------------

Marked as reviewed by psandoz (no project role).

PR: https://git.openjdk.java.net/jmh/pull/22


More information about the jmh-dev mailing list