RFR: CODETOOLS-7902927: JMH: Support HTML flamegraphs for async-profiler [v2]

Nick Evgeniev github.com+5995748+nevgeniev at openjdk.java.net
Wed May 5 17:16:02 UTC 2021


On Wed, 5 May 2021 16:59:22 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Turns out, newer async-profiler silently eats "-o svg", expecting "-o flamegraph". It now generates HTML flamegraphs too. We need to handle both new and old flamegraph styles.
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Simplify

jmh-core/src/main/java/org/openjdk/jmh/profile/AsyncProfiler.java line 348:

> 346: 
> 347:     static boolean svgFlamegraphs(String ver) {
> 348:         if (ver.startsWith("1")) {

well. they dropped svg @ version 1.8.5 so check is not valid :/

-------------

PR: https://git.openjdk.java.net/jmh/pull/36


More information about the jmh-dev mailing list