RFR: CODETOOLS-7902927: JMH: Support HTML flamegraphs for async-profiler [v2]

Aleksey Shipilev shade at openjdk.java.net
Wed May 5 17:16:03 UTC 2021


On Wed, 5 May 2021 17:11:26 GMT, Nick Evgeniev <github.com+5995748+nevgeniev at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplify
>
> jmh-core/src/main/java/org/openjdk/jmh/profile/AsyncProfiler.java line 348:
> 
>> 346: 
>> 347:     static boolean svgFlamegraphs(String ver) {
>> 348:         if (ver.startsWith("1")) {
> 
> well. they dropped svg @ version 1.8.5 so check is not valid :/

See the discussion here: jvm-profiling-tools/async-profiler#427 -- I think Andrei made a mistake with tagging the repo, but actual 1.8.5 release should be fine.

-------------

PR: https://git.openjdk.java.net/jmh/pull/36


More information about the jmh-dev mailing list