RFR: CODETOOLS-7903056: perfasm can report wrong stub name [v2]

Nick Gasson ngasson at openjdk.java.net
Thu Nov 11 07:48:13 UTC 2021


> This patch changes `IntervalMap::get` to check that the value falls within an interval's high/low bounds. Otherwise it returns the closest entry < value which can be misleading.
> 
> Example of the new output, where previously the `<unknown>` line reported the wrong stub routine:
> 
> 
>  18.19%           libjvm.so  ProgrammableUpcallHandler::on_entry
>  13.94%                      <unknown>
>   9.39%           libjvm.so  ProgrammableUpcallHandler::on_exit
>   8.36%         c2, level 4  java.lang.invoke.LambdaForm$MH.0x00000008001b8400::invoke, version 1595

Nick Gasson has updated the pull request incrementally with one additional commit since the last revision:

  Address review comments

-------------

Changes:
  - all: https://git.openjdk.java.net/jmh/pull/54/files
  - new: https://git.openjdk.java.net/jmh/pull/54/files/cfa2440f..a61524e1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmh&pr=54&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmh&pr=54&range=00-01

  Stats: 27 lines in 1 file changed: 26 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmh/pull/54.diff
  Fetch: git fetch https://git.openjdk.java.net/jmh pull/54/head:pull/54

PR: https://git.openjdk.java.net/jmh/pull/54


More information about the jmh-dev mailing list