RFR: CODETOOLS-7903056: perfasm can report wrong stub name [v2]

Aleksey Shipilev shade at openjdk.java.net
Thu Nov 11 07:48:15 UTC 2021


On Thu, 11 Nov 2021 07:44:45 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

>> This patch changes `IntervalMap::get` to check that the value falls within an interval's high/low bounds. Otherwise it returns the closest entry < value which can be misleading.
>> 
>> Example of the new output, where previously the `<unknown>` line reported the wrong stub routine:
>> 
>> 
>>  18.19%           libjvm.so  ProgrammableUpcallHandler::on_entry
>>  13.94%                      <unknown>
>>   9.39%           libjvm.so  ProgrammableUpcallHandler::on_exit
>>   8.36%         c2, level 4  java.lang.invoke.LambdaForm$MH.0x00000008001b8400::invoke, version 1595
>
> Nick Gasson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

Looks fine, thanks.

-------------

Marked as reviewed by shade (Committer).

PR: https://git.openjdk.java.net/jmh/pull/54


More information about the jmh-dev mailing list