RFR: CODETOOLS-7903351: JMH: Update pre-integration testing workflows [v2]

Aleksey Shipilev shade at openjdk.org
Thu Oct 13 15:50:12 UTC 2022


On Wed, 12 Oct 2022 22:59:11 GMT, Róbert Papp <duke at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Drop JDK 7 from testing
>
> .github/workflows/pre-integration.yml line 19:
> 
>> 17:     strategy:
>> 18:       matrix:
>> 19:         java: [8, 11, 17, 19, 20-ea]
> 
> Huh, interesting, unlucky 13 releases old J7 is not supported by 20 :)
> Since the problem seems to be with compilation, this is an interesting blog post for this project (probably not in scope of this PR, but something to muse on): https://jakewharton.com/build-on-latest-java-test-through-lowest-java/

Honestly, it might be just a good time to drop JDK 7 support: #86.

> .github/workflows/pre-integration.yml line 28:
> 
>> 26:     - uses: actions/checkout at v3
>> 27:     - name: Set up JDK ${{ matrix.java }}
>> 28:       uses: actions/setup-java at v1
> 
> Did you miss a version bump here?
> To get this benefit? https://github.com/openjdk/jmh/pull/73#discussion_r920871893
> 
> This release added the flag: https://github.com/actions/setup-java/releases/tag/v2.3.0

Right, thanks for catching this!

-------------

PR: https://git.openjdk.org/jmh/pull/84


More information about the jmh-dev mailing list