RFR: CODETOOLS-7903351: JMH: Update pre-integration testing workflows [v2]

Róbert Papp duke at openjdk.org
Fri Oct 14 07:37:24 UTC 2022


On Thu, 13 Oct 2022 15:44:56 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> .github/workflows/pre-integration.yml line 19:
>> 
>>> 17:     strategy:
>>> 18:       matrix:
>>> 19:         java: [8, 11, 17, 19, 20-ea]
>> 
>> Huh, interesting, unlucky 13 releases old J7 is not supported by 20 :)
>> Since the problem seems to be with compilation, this is an interesting blog post for this project (probably not in scope of this PR, but something to muse on): https://jakewharton.com/build-on-latest-java-test-through-lowest-java/
>
> Honestly, it might be just a good time to drop JDK 7 support: #86.

Nice PR! The blog post still applies though for the future ;)

>> .github/workflows/pre-integration.yml line 28:
>> 
>>> 26:     - uses: actions/checkout at v3
>>> 27:     - name: Set up JDK ${{ matrix.java }}
>>> 28:       uses: actions/setup-java at v1
>> 
>> Did you miss a version bump here?
>> To get this benefit? https://github.com/openjdk/jmh/pull/73#discussion_r920871893
>> 
>> This release added the flag: https://github.com/actions/setup-java/releases/tag/v2.3.0
>
> Right, thanks for catching this!

There's 3.5.1 too, now that it's being updated, probably go to actual latest, so you get better support of newer Java versions.

-------------

PR: https://git.openjdk.org/jmh/pull/84


More information about the jmh-dev mailing list