RFR: 7903696: JMH: Add xctrace-based perfasm profiler for macOS [v3]

Filipp Zhinkin fzhinkin at openjdk.org
Mon Apr 22 20:10:55 UTC 2024


On Fri, 19 Apr 2024 17:37:53 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Filipp Zhinkin has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - 7903696: Removed an option unsupported by older xctrace version
>>  - 7903696: Support legacy backtrace format
>>  - 7903696: Detect xctrace using xcode-select
>
> jmh-core/src/main/java/org/openjdk/jmh/profile/XCTraceTableProfileHandler.java line 288:
> 
>> 286: 
>> 287:     private static abstract class TraceElement {
>> 288:         public final long id;
> 
> Here and later in `TraceElement` subclasses. For extra sanity, can you turn these fields `private` and expose proper (immutable) getters for them?

Sure! Also, encapsulated mutable fields.

-------------

PR Review Comment: https://git.openjdk.org/jmh/pull/130#discussion_r1575303035


More information about the jmh-dev mailing list