RFR: 7903696: JMH: Add xctrace-based perfasm profiler for macOS [v3]

Aleksey Shipilev shade at openjdk.org
Tue Apr 23 09:32:44 UTC 2024


On Tue, 23 Apr 2024 09:21:51 GMT, Filipp Zhinkin <fzhinkin at openjdk.org> wrote:

>> OK, that's fine. Do we need `} else {` with some exception throwing for exhaustiveness?
>
> We don't: TOC-file contains multiple tables, and it's OK if a table we're currently looking at is not listed in `ProfilingTableType`. If there were no supported tables, an exception would be thrown later by the `XCTraceAsmProfiler.`

OK.

-------------

PR Review Comment: https://git.openjdk.org/jmh/pull/130#discussion_r1575947500


More information about the jmh-dev mailing list