RFR: 7903696: JMH: Add xctrace-based perfasm profiler for macOS [v3]
Filipp Zhinkin
fzhinkin at openjdk.org
Tue Apr 23 09:24:42 UTC 2024
On Tue, 23 Apr 2024 09:02:52 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> It won't work here as loading the enum's field is not a compile-time const expression.
>>
>> And converting a `schema` value into a `ProfilingTableType` and then switching over it seems to be an overkill here (but if you disagree, I can rewrite it).
>
> OK, that's fine. Do we need `} else {` with some exception throwing for exhaustiveness?
We don't: TOC-file contains multiple tables, and it's OK if a table we're currently looking at is not listed in `ProfilingTableType`. If there were no supported tables, an exception would be thrown later by the `XCTraceAsmProfiler.`
-------------
PR Review Comment: https://git.openjdk.org/jmh/pull/130#discussion_r1575936046
More information about the jmh-dev
mailing list