jmx-dev Review request: 8049303: Transient network problems cause JMX thread to fail silenty

[shanliang]

Jaroslav Bachorik wrote:
> Hi,
>
> On 09/11/2014 12:31 PM, Daniel Fuchs wrote:
>> On 9/10/14 9:45 PM, shanliang wrote:
>>> Oh, not one retry attempt fetching the next batch of notifications, but
>>> the *SAME* batch of notifications.
>>>
>>> http://cr.openjdk.java.net/~sjiang/JDK-8049303/02/
>>> <http://cr.openjdk.java.net/%7Esjiang/JDK-8049303/02/>
>>>
>>> Shanliang
>>>>
>>
>> This looks good Shanliang!
>>
>
> I have just one nit - rename "throwsDeserializationException()" to 
> "rethrowDeserializationException()" - it makes its purpose clear.
I have already added internal comments to explain the call, but why not.
>
> Otherwise - Thumbs Up!
Thanks for review!

Shanliang
>
> Cheers,
>
> -JB-
>> Make sure to rerun all the JCK/JDK tests before pushing.
>> This was really a tricky problem!
>>
>> best regards,
>>
>> -- daniel
>