JOL Hotspot SA Support and Compressed References Implementation

[Aleksey Shipilev]

Hi Serkan,

On 01/13/2015 07:06 PM, Serkan ÖZAL wrote:
>>  * Still, Javadoc failures when building.
>>   
> Weird, on my machine (using JDK 8), Javadoc is generated successfully
> just with 4 warnings about Unsafe API usage.
> Could you send Javadoc fail messages ?


[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:2.9:jar (attach-javadoc)
on project jol-core: MavenReportException: Error while creating archive:
[ERROR] Exit code: 1 -
/home/shade/projects/jol/jol-core/src/main/java/org/openjdk/jol/util/HS_SA_Support.java:62:
error: incorrect use of inline tag
[ERROR] *          @link http://en.wikipedia.org/wiki/Sudo
[ERROR] ^
[ERROR]
/home/shade/projects/jol/jol-core/src/main/java/org/openjdk/jol/util/sa/HS_SA_Processor.java:35:
error: malformed HTML
[ERROR] * Please see <a
href="http://www.oracle.com/technetwork/articles/java/javaserial-1536170.html>http://www.oracle.com/technetwork/articles/java/javaserial-1536170.html</a>
for more details.
[ERROR] ^
[ERROR]
/home/shade/projects/jol/jol-core/src/main/java/org/openjdk/jol/util/sa/HS_SA_Processor.java:35:
error: bad use of '>'
[ERROR] * Please see <a
href="http://www.oracle.com/technetwork/articles/java/javaserial-1536170.html>http://www.oracle.com/technetwork/articles/java/javaserial-1536170.html</a>
for more details.
[ERROR] ^
[ERROR]
/home/shade/projects/jol/jol-core/src/main/java/org/openjdk/jol/util/sa/HS_SA_Processor.java:35:
error: unexpected end tag: </a>
[ERROR] * Please see <a
href="http://www.oracle.com/technetwork/articles/java/javaserial-1536170.html>http://www.oracle.com/technetwork/articles/java/javaserial-1536170.html</a>
for more details.
[ERROR] ^

>>  * I thought you better to return HS_SA_Result from execute* methods,
>> not blank Serializable. Also, it may make sense to check the types
>> before downcasting.
>>   
> In fact, I had removed them after your comments for first patch. Seems
> that I got you wrong :)
> So should I add "HS_SA_Result" (just a marker interface extends from
> Serializable) interface back ? WDYT ?

Yes, that's the sanest option, IMO.

Thanks,
-Aleksey.