JOL Hotspot SA Support and Compressed References Implementation

[Serkan ÖZAL]

Hi Aleksey,
> On 01/13/2015 12:55 AM, Serkan ÖZAL wrote:
>   
>> Hi Aleksey,
>>
>> I have just updated my patch as your suggestions. I hope it is OK.
>> Waiting for your feedbacks.
>>
>> 3rd (latest) version of patch is attached to mail.
>>     
>
> Thanks!
>
>  * Still, Javadoc failures when building.
>   
Weird, on my machine (using JDK 8), Javadoc is generated successfully 
just with 4 warnings about Unsafe API usage.
Could you send Javadoc fail messages ?

>  * HS_SA_Support: sudo autodetection scheme is broken: you expect
> ProcessAttachFailedException, but getting it wrapped in RuntimeException
> instead. That's also why it prints "null":
>  "Initial Hotspot SA process attach check failed (null) So skipping
> Hotspot SA support ...
>   
Right. Fixed.

>  * It would make sense to steal FileUtils.safelyClose from JMH:
>  http://hg.openjdk.java.net/code-tools/jmh/file/d15ebde32b25/jmh-core/src/main/java/org/openjdk/jmh/util/FileUtils.java#l203
>   
OK. Copied the "safelyClose" methods to "HS_SA_Support" class.

>  * I thought you better to return HS_SA_Result from execute* methods,
> not blank Serializable. Also, it may make sense to check the types
> before downcasting.
>   
In fact, I had removed them after your comments for first patch. Seems 
that I got you wrong :)
So should I add "HS_SA_Result" (just a marker interface extends from 
Serializable) interface back ? WDYT ?

> Otherwise, it looks very good. I would need to do some deeper reading
> and testing of VMSupport changes before commit.
>
> Thanks,
> -Aleksey.
>   
Great.

Regards.

--

Serkan ÖZAL