RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]

[Aleksey Shipilev]

On Sun, 25 Sep 2022 07:27:26 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

>> jol-core/src/main/java/org/openjdk/jol/ljv/GraphvizVisualization.java line 55:
>> 
>>> 53:     public void diagramBegin() {
>>> 54:         out.setLength(0); // Clearing String Builder before starting new DOT
>>> 55:         out.append("digraph Java {\n")
>> 
>> Here and later, `\n` should actually be `System.lineSeparator()` to provide platform-independent line breaks. This would probably make golden test output platform-dependent, though? We can rehash this after the integration.
>
> No it won't be a problem for Approvals tests, as far as I understand it can treat the line ending discrepancies correctly.
> However I can notice `\n` in `OptionFormatter` and `ClassLayout`, so maybe postpone the line ending problem?

Okay, sounds fine.

-------------

PR: https://git.openjdk.org/jol/pull/24