RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]

[Aleksey Shipilev]

On Mon, 22 Aug 2022 08:26:47 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Ivan Ponomarev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update copyright notice, lint
>
> jol-core/src/main/java/org/openjdk/jol/ljv/Introspection.java line 32:
> 
>> 30: import java.util.List;
>> 31: 
>> 32: public interface Introspection {
> 
> Now that LJV is in JOL, can we "just" use its internals to introspect stuff, without doing LJV-specific walk? What's the plan here?

This comment is still not addressed.

> jol-core/src/main/java/org/openjdk/jol/ljv/IntrospectionWithReflectionAPI.java line 54:
> 
>> 52:         }
>> 53: 
>> 54:         // Не заци��ливаемся, смотрим обошл�� мы этот объект уже или ещё нет.
> 
> Russian comment :)

This comment is still not addressed.

> jol-core/src/main/java/org/openjdk/jol/ljv/LJV.java line 44:
> 
>> 42: //-   You should have received a copy of the GNU General Public License along
>> 43: //-   with this program; if not, write to the Free Software Foundation, Inc.,
>> 44: //-   59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
> 
> Wait a second, what's this? Does this file borrow some external code?

This comment is still not addressed.

> jol-core/src/main/java/org/openjdk/jol/ljv/Quote.java line 53:
> 
>> 51:                 sb.append(c);
>> 52:             else
>> 53:                 sb.append("\\\\0u").append(Integer.toHexString(c));
> 
> Braces, please.

This comment was not addressed.

> jol-core/src/main/java/org/openjdk/jol/ljv/pom.xml line 1:
> 
>> 1: <?xml version="1.0" encoding="UTF-8"?>
> 
> Weird to see this `pom.xml` in sources. Do you mean to merge parts of it into `jol-core/pom.xml`?

This comment was not addressed.

> jol-core/src/main/java/org/openjdk/jol/ljv/provider/ArrayElementAttributeProvider.java line 27:
> 
>> 25: package org.openjdk.jol.ljv.provider;
>> 26: 
>> 27: //@FunctionalInterface
> 
> Leftover comment.

This comment was not addressed.

-------------

PR: https://git.openjdk.org/jol/pull/24