FOR REVIEW: CODETOOLS-7900909 trailing space in JTR entry for script

Mike Ershov Mikhail.Ershov at oracle.com
Fri May 23 10:59:56 UTC 2014


Hi,

In general, this is correct fix. But I'd simply surround it trim(), 
something like this:

String sargs = (this.getClass().getName() + " " + 
StringArray.join(scriptArgs)).trim();
testResult.putProperty(TestResult.SCRIPT,  sargs);

Again, your code is correct, this is just a question of preferences.

Mike

On 05/19/2014 12:54 PM, Brian Kurotsuchi wrote:
> http://cr.openjdk.java.net/~bkurotsu/7900909/
>
> As you can see in the code, the old code will generate a trailing 
> space if the args are zero length.
>
> No problems reported with this, I just noticed this while debugging 
> something else.



More information about the jtharness-dev mailing list