FOR REVIEW: CODETOOLS-7900909 trailing space in JTR entry for script

Brian Kurotsuchi brian.kurotsuchi at oracle.com
Thu May 22 23:03:28 UTC 2014


You are right, that is a simple solution.  I already tested this version 
though, so let's go with the more complex code.  :)



On 5/23/14 04:59, Mike Ershov wrote:
> Hi,
>
> In general, this is correct fix. But I'd simply surround it trim(), 
> something like this:
>
> String sargs = (this.getClass().getName() + " " + 
> StringArray.join(scriptArgs)).trim();
> testResult.putProperty(TestResult.SCRIPT,  sargs);
>
> Again, your code is correct, this is just a question of preferences.
>
> Mike
>
> On 05/19/2014 12:54 PM, Brian Kurotsuchi wrote:
>> http://cr.openjdk.java.net/~bkurotsu/7900909/
>>
>> As you can see in the code, the old code will generate a trailing 
>> space if the args are zero length.
>>
>> No problems reported with this, I just noticed this while debugging 
>> something else.
>



More information about the jtharness-dev mailing list