RFR: crashonly extension for jtharness - for fastdebug testing [v2]

[Jiří Vaněk]

On Tue, 15 Aug 2023 14:17:49 GMT, andrlos <duke at openjdk.org> wrote:

>> fastdebug jvm build testing is about finding out whether the jvm crashes or not... This means we are only interested in crashes and not regular failures when testing fastdebug jvms. This results in this PR that adds "crashonly" atribute for this exact case to jtharness default test runner. 
>> The intention is to get this addition to work with jtreg without breaking any other jtharness functionality.
>
> andrlos has updated the pull request incrementally with one additional commit since the last revision:
> 
>   deleting forgotten comment

src/com/sun/javatest/DefaultTestRunner.java line 231:

> 229:      * checks for the occurrence of hs_err_pid file that suggest that crash happened during execution
> 230:      **/
> 231:     private boolean didCrash(TestDescription td){

To keep the conventions, maybe `isCrashed` is better?

src/com/sun/javatest/DefaultTestRunner.java line 233:

> 231:     private boolean didCrash(TestDescription td){
> 232:         Pattern pattern = Pattern.compile("^hs_err_.*");
> 233:         return Arrays.stream(td.getDir().list()).anyMatch(pattern.asPredicate());

Maybe it would be nice to return all found hs_err pids,  instead of just boolean  (so false would be an empty list)
Future processor very likely would like to print the hs_err files out? At least truncated?

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/49#discussion_r1294670529
PR Review Comment: https://git.openjdk.org/jtharness/pull/49#discussion_r1294673193