RFR: crashonly extension for jtharness - for fastdebug testing [v2]

[andrlos]

On Tue, 15 Aug 2023 14:27:29 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> andrlos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   deleting forgotten comment
>
> src/com/sun/javatest/DefaultTestRunner.java line 231:
> 
>> 229:      * checks for the occurrence of hs_err_pid file that suggest that crash happened during execution
>> 230:      **/
>> 231:     private boolean didCrash(TestDescription td){
> 
> To keep the conventions, maybe `isCrashed` is better?

well the test already ran and therefore I thought that it already did/didn't crash in the time this method  has been called

> src/com/sun/javatest/DefaultTestRunner.java line 233:
> 
>> 231:     private boolean didCrash(TestDescription td){
>> 232:         Pattern pattern = Pattern.compile("^hs_err_.*");
>> 233:         return Arrays.stream(td.getDir().list()).anyMatch(pattern.asPredicate());
> 
> Maybe it would be nice to return all found hs_err pids,  instead of just boolean  (so false would be an empty list)
> Future processor very likely would like to print the hs_err files out? At least truncated?

hmm ok, good suggestion

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/49#discussion_r1294727466
PR Review Comment: https://git.openjdk.org/jtharness/pull/49#discussion_r1294731187