RFR: crashonly extension for jtharness - for fastdebug testing [v2]
andrlos
duke at openjdk.org
Tue Aug 15 19:36:27 UTC 2023
On Tue, 15 Aug 2023 16:18:58 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:
>> andrlos has updated the pull request incrementally with one additional commit since the last revision:
>>
>> deleting forgotten comment
>
> src/com/sun/javatest/DefaultTestRunner.java line 207:
>
>> 205: if(this.crashOnly && result.getStatus().getType() == Status.FAILED && ! this.didCrash(td)){
>> 206: result = new TestResult(td, new Status(Status.PASSED, "only a regular fail"));
>> 207: if(result.getStatus().getType() == Status.PASSED){
>
> Maybe such result should be skipped? Maybe it shcould be configurable whether such test should be conisedered as skipped or passed?
@judovana I am not aware of any mechanic that would be doing such a thing as configure the behaviour of individual test results already, therefore there would have to be a new mechanic in place that would take care of sending the argument from jtreg to jtharness eventually.. I am generally ok with marking these regularly failed tests as skipped and if anyone would want to make it configurable to switch between the SKIPPED & PASSED, then be my guest, however for the usecase of the enhancement and testing fastdebug jvms, this should be more than sufficient.
-------------
PR Review Comment: https://git.openjdk.org/jtharness/pull/49#discussion_r1295027330
More information about the jtharness-dev
mailing list