RFR: crashonly extension for jtharness - for fastdebug testing [v2]

Jiří Vaněk jvanek at openjdk.org
Wed Aug 16 07:49:18 UTC 2023


On Tue, 15 Aug 2023 19:32:05 GMT, andrlos <duke at openjdk.org> wrote:

>> src/com/sun/javatest/DefaultTestRunner.java line 207:
>> 
>>> 205:             if(this.crashOnly && result.getStatus().getType() == Status.FAILED && ! this.didCrash(td)){
>>> 206:                 result = new TestResult(td, new Status(Status.PASSED, "only a regular fail"));
>>> 207:                 if(result.getStatus().getType() == Status.PASSED){
>> 
>> Maybe such result should be skipped? Maybe it shcould be configurable whether such test should be conisedered as skipped or passed?
>
> @judovana I am not aware of any mechanic that would be doing such a thing as configure the behaviour of individual test results already, therefore there would have to be a new mechanic in place that would take care of sending the argument from jtreg to jtharness eventually.. I am generally ok with marking these regularly failed tests as skipped and if anyone would want to make it configurable to switch between the SKIPPED & PASSED, then be my guest, however for the usecase of the enhancement and testing fastdebug jvms, this should be more than sufficient.

Maybe.. :) Up to you. To make the --crashes to take parameter would not be that hard.  Eg --crashOnly[=passed] or --crashOnly=ignored...

Buy  you are right, there may be many of similar tweaks, so  rather keep the --crashOnly simple, and add config later.

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/49#discussion_r1295507933


More information about the jtharness-dev mailing list