RFR: crashonly extension for jtharness - for fastdebug testing [v2]

andrlos duke at openjdk.org
Tue Aug 15 19:36:29 UTC 2023


On Tue, 15 Aug 2023 15:11:14 GMT, andrlos <duke at openjdk.org> wrote:

>> src/com/sun/javatest/DefaultTestRunner.java line 233:
>> 
>>> 231:     private boolean didCrash(TestDescription td){
>>> 232:         Pattern pattern = Pattern.compile("^hs_err_.*");
>>> 233:         return Arrays.stream(td.getDir().list()).anyMatch(pattern.asPredicate());
>> 
>> Maybe it would be nice to return all found hs_err pids,  instead of just boolean  (so false would be an empty list)
>> Future processor very likely would like to print the hs_err files out? At least truncated?
>
> hmm ok, good suggestion

I will redo this part and there will be another function getCrashes that will return list of pids and hserr txt contents in crash objects and the function didCrash will only check whether the list is empty or not.
Thanks for the suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/49#discussion_r1295028568


More information about the jtharness-dev mailing list