RFR: 7903519 : jtreg/jtharness is missing features for basic crash testing [v6]

[Vladimir Sitnikov]

On Thu, 14 Dec 2023 13:21:12 GMT, andrlos <duke at openjdk.org> wrote:

>> this does not exactly add a crash testing option, however it allows users to define their own resultModifiers that they can force jtharness to use via advertising their resultModifier service in META-INF. I tested it with basic crashOnlyModificator and it works as intended - allows me to correctly skip and pass all the regular failures and only leaves me with crash tests as failures. Perfect for corner cases like JVM testing and such.
>> Also checked correct behavior in the logs, where the regular failure is still being reported and only the justification of the result modification is added at the bottom.
>
> andrlos has updated the pull request incrementally with one additional commit since the last revision:
> 
>   more comment edits

src/com/sun/javatest/Script.java line 215:

> 213: 
> 214:     /**
> 215:      * tries to search for a statusTransformer, no status transformations will be done if the value is null

Technically speaking, the field does not "try to search"

I would suggest something like

Suggestion:

     * Contains {@link StatusTransformer} that transforms the test result status, or {@code null} if no transformer service was found.

src/com/sun/javatest/Script.java line 217:

> 215:      * tries to search for a statusTransformer, no status transformations will be done if the value is null
> 216:      */
> 217:     private static final StatusTransformer statusTransformer = searchStatusTransformer();

Typically, `static final` fields are named in `UPPER_CASE`

Suggestion:

    private static final StatusTransformer STATUS_TRANSFORMER = loadStatusTransformer();

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/57#discussion_r1426712482
PR Review Comment: https://git.openjdk.org/jtharness/pull/57#discussion_r1426713320