RFR: 7903519 : jtreg/jtharness is missing features for basic crash testing [v6]

[andrlos]

On Thu, 14 Dec 2023 13:22:22 GMT, Vladimir Sitnikov <vsitnikov at openjdk.org> wrote:

>> andrlos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more comment edits
>
> src/com/sun/javatest/Script.java line 215:
> 
>> 213: 
>> 214:     /**
>> 215:      * tries to search for a statusTransformer, no status transformations will be done if the value is null
> 
> Technically speaking, the field does not "try to search"
> 
> I would suggest something like
> 
> Suggestion:
> 
>      * Contains {@link StatusTransformer} that transforms the test result status, or {@code null} if no transformer service was found.

sure, sorry comments and naming are not my strong suite

> src/com/sun/javatest/Script.java line 217:
> 
>> 215:      * tries to search for a statusTransformer, no status transformations will be done if the value is null
>> 216:      */
>> 217:     private static final StatusTransformer statusTransformer = searchStatusTransformer();
> 
> Typically, `static final` fields are named in `UPPER_CASE`
> 
> Suggestion:
> 
>     private static final StatusTransformer STATUS_TRANSFORMER = loadStatusTransformer();

oh yeah.. forgot about that convention, will change :-)

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/57#discussion_r1426718690
PR Review Comment: https://git.openjdk.org/jtharness/pull/57#discussion_r1426719214