RFR: exracting method to fill in result status to allow for overriding in implementations of Script

Jiří Vaněk jvanek at openjdk.org
Wed Jan 10 07:51:42 UTC 2024


On Tue, 9 Jan 2024 20:43:42 GMT, andrlos <duke at openjdk.org> wrote:

> This is an alternative approach to https://github.com/openjdk/jtharness/pull/57
> counting on Script subclasses that will allow for such modifications.

src/com/sun/javatest/Script.java line 487:

> 485:      * @param execStatus Status object to fill into the testResultToFill
> 486:      */
> 487:     protected void fillTestExecutionStatus(TestResult testResultToFill, Status execStatus) {

I would  suggest `setTestResultStatus` or `modifyTestResultStatus`, as we are dealing with testResult variable ; or `setTestRunStatus` or `modifyTestRuntStatus` as we are called in `run`. But you know better, just ideas from point of view what I would be searching in autocompletion (fill is unlikely, execution more likely, still  rare)

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/59#discussion_r1446998410


More information about the jtharness-dev mailing list