RFR: exracting method to fill in result status to allow for overriding in implementations of Script

[andrlos]

On Wed, 10 Jan 2024 07:49:02 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> This is an alternative approach to https://github.com/openjdk/jtharness/pull/57
>> counting on Script subclasses that will allow for such modifications.
>
> src/com/sun/javatest/Script.java line 487:
> 
>> 485:      * @param execStatus Status object to fill into the testResultToFill
>> 486:      */
>> 487:     protected void fillTestExecutionStatus(TestResult testResultToFill, Status execStatus) {
> 
> I would  suggest `setTestResultStatus` or `modifyTestResultStatus`, as we are dealing with testResult variable ; or `setTestRunStatus` or `modifyTestRuntStatus` as we are called in `run`. But you know better, just ideas from point of view what I would be searching in autocompletion (fill is unlikely, execution more likely, still  rare)

well I would vote the "modify" based names out, since by default this wont be changing anything..

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/59#discussion_r1447422906