RFR: CODETOOLS-7903037: Allow Subtest ids with dashes and underscores

Jonathan Gibbons jjg at openjdk.java.net
Sat Oct 30 00:15:19 UTC 2021


On Fri, 29 Oct 2021 15:06:31 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> At the moment the jtreg launcher does not accept subtest ids that contain dashes or underscores. For example:
> 
> 
> thomas at starfish:jtreg ... source/test/hotspot/jtreg/runtime/Metaspace/elastic/TestMetaspaceAllocationMT2.java#debug-none
> Error: Not a test or directory containing tests: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2.java#debug-none
> 
> 
> Patch fixes this:
> 
> 
> thomas at starfish:jtreg ... source/test/hotspot/jtreg/runtime/Metaspace/elastic/TestMetaspaceAllocationMT2.java#debug-none
> Test results: passed: 1

I was skeptical of this until I found earlier code that in `RegressionTestFinder` that also accepts dashes and underscores.

CODETOOLS-7902447: support custom id
https://github.com/openjdk/jtreg/commit/99c41c093ea92a0011a14a85f50cc9938a223f1a#diff-f3a1aee806be54922ee1a5c450a87f21b37a1b3aef47e99f92f1a00dca7bdcb9

If you `/integrate`, I will `/sponsor` the change.

-------------

Marked as reviewed by jjg (Lead).

PR: https://git.openjdk.java.net/jtreg/pull/30


More information about the jtreg-dev mailing list