RFR: CODETOOLS-7903037: Allow Subtest ids with dashes and underscores

Thomas Stuefe stuefe at openjdk.java.net
Sat Oct 30 07:08:19 UTC 2021


On Fri, 29 Oct 2021 21:49:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> At the moment the jtreg launcher does not accept subtest ids that contain dashes or underscores. For example:
>> 
>> 
>> thomas at starfish:jtreg ... source/test/hotspot/jtreg/runtime/Metaspace/elastic/TestMetaspaceAllocationMT2.java#debug-none
>> Error: Not a test or directory containing tests: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2.java#debug-none
>> 
>> 
>> Patch fixes this:
>> 
>> 
>> thomas at starfish:jtreg ... source/test/hotspot/jtreg/runtime/Metaspace/elastic/TestMetaspaceAllocationMT2.java#debug-none
>> Test results: passed: 1
>
> Paging @jonathan-gibbons !

Thanks @dholmes-ora and @jonathan-gibbons for reviews and sponsoring.

I changed the expression somewhat. I realized that I did not have to escape the dash in the character class, and then I unified the expression with the one Jonathan mentioned, in RegressionTestFinder.java (removing the embedded case insensitive flag and replacing it with explicit `A-Z`).

I re-tested with all kinds of subtest ids.

Cheers, Thomas

-------------

PR: https://git.openjdk.java.net/jtreg/pull/30


More information about the jtreg-dev mailing list