RFR: 7903324: Improve per-class reporting of JUnit tests, in .jtr file [v2]
Jonathan Gibbons
jjg at openjdk.org
Fri Nov 4 20:15:11 UTC 2022
On Thu, 3 Nov 2022 16:53:59 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Improve per-class reporting of JUnit tests by using a custom `TestExecutionListener` in `JUnitRunner`.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>
> More comments addressed
Marked as reviewed by jjg (Lead).
Should there be an entry in the changeling for this?
src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 129:
> 127: String testQuery = System.getProperty("test.query");
> 128: LauncherDiscoveryRequest request = LauncherDiscoveryRequestBuilder.request()
> 129: // if test.query is set, treat it as a method name to be executed
Note sure why you have moved this into the middle of chained function calls. If anything, I would move it to before line 127, which is the line that actually uses `test.query`, as compared to `testQuery`
-------------
PR: https://git.openjdk.org/jtreg/pull/127
More information about the jtreg-dev
mailing list