RFR: 7903324: Improve per-class reporting of JUnit tests, in .jtr file [v2]

Christian Stein cstein at openjdk.org
Tue Nov 8 13:37:44 UTC 2022


On Fri, 4 Nov 2022 20:08:45 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More comments addressed
>
> src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 129:
> 
>> 127:             String testQuery = System.getProperty("test.query");
>> 128:             LauncherDiscoveryRequest request = LauncherDiscoveryRequestBuilder.request()
>> 129:                 // if test.query is set, treat it as a method name to be executed
> 
> Note sure why you have moved this into the middle of chained function calls. If anything, I would move it to before line 127, which is the line that actually uses `test.query`, as compared to `testQuery`

The movement was not intended  - will move it before line 127.

-------------

PR: https://git.openjdk.org/jtreg/pull/127


More information about the jtreg-dev mailing list