RFR: 7903601 : simple fix for jtr.xml logs missing description with shell tests
Christian Stein
cstein at openjdk.org
Wed Dec 6 15:55:11 UTC 2023
On Tue, 5 Dec 2023 18:17:36 GMT, andrlos <duke at openjdk.org> wrote:
> issue:
> https://bugs.openjdk.org/browse/CODETOOLS-7903601
>
> with "-xml" argument when a shell driven test fails, the only thing you are getting in jtr.xml file as an explanation is the exit code which is not very helpful.. this is a fix for that which aligns the behavior of shell tests with that of java tests. The solution is up for a discussion, I just did the simplest and sturdiest solution I could think of.. in case there is no "main" section in the original jtr file, the xmlwriter in jtreg tries to iterate the sections again for "shell" section and writes the failure it finds there to the jtr.xml log
Please fix the PR title to match the issue title.
Wouldn't a first-hit-wins strategy suffice here? Something like this around line 181 of `XMLWriter.java`:
if (titles[i].equals("main") || titles[i].equals("shell")) {
-------------
PR Comment: https://git.openjdk.org/jtreg/pull/175#issuecomment-1843181655
More information about the jtreg-dev
mailing list