RFR: 7903601 : simple fix for jtr.xml logs missing description with shell tests

Jonathan Gibbons jjg at openjdk.org
Wed Dec 6 17:08:08 UTC 2023


On Tue, 5 Dec 2023 18:17:36 GMT, andrlos <duke at openjdk.org> wrote:

> issue:
> https://bugs.openjdk.org/browse/CODETOOLS-7903601
> 
> with "-xml" argument when a shell driven test fails, the only thing you are getting in jtr.xml file as an explanation is the exit code which is not very helpful.. this is a fix for that which aligns the behavior of shell tests with that of java tests. The solution is up for a discussion, I just did the simplest and sturdiest solution I could think of.. in case there is no "main" section in the original jtr file, the xmlwriter in jtreg tries to iterate the sections again for "shell" section and writes the failure it finds there to the jtr.xml log

src/share/classes/com/sun/javatest/regtest/report/XMLWriter.java line 181:

> 179:     private String getOutput(String name) throws TestResult.Fault {
> 180:         String[] titles = tr.getSectionTitles();
> 181:         //first we are looking for a "main" section in jtr log.. if none is found it is usually cuz the test is executed via script, hence under "shell" section

Use "because", not "cuz"

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/175#discussion_r1417676615


More information about the jtreg-dev mailing list