RFR: 7903430: Improve reporting for errors in JUnit's lifecycle methods

Jonathan Gibbons jjg at openjdk.org
Mon Feb 13 23:18:55 UTC 2023


On Fri, 10 Feb 2023 09:04:24 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change set ensuring that all exceptions thrown in JUnit's lifecycle methods are reported.
> 
> Prior to this PR, only exceptions thrown by "test identifiers" were reported.
> Now all kinds of identifiers, which include "container identifiers", are generating a report when the execution result is in `ABORTED` or `FAILED` state.

src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 235:

> 233:         @Override
> 234:         public void executionFinished(TestIdentifier identifier, TestExecutionResult result) {
> 235:             /* if (identifier.isTest()) */ {

Remove commented out code, and maybe the remaining curly braces?

-------------

PR: https://git.openjdk.org/jtreg/pull/147


More information about the jtreg-dev mailing list