RFR: 7903430: Improve reporting for errors in JUnit's lifecycle methods

Christian Stein cstein at openjdk.org
Tue Feb 14 07:01:11 UTC 2023


On Mon, 13 Feb 2023 23:16:28 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review this change set ensuring that all exceptions thrown in JUnit's lifecycle methods are reported.
>> 
>> Prior to this PR, only exceptions thrown by "test identifiers" were reported.
>> Now all kinds of identifiers, which include "container identifiers", are generating a report when the execution result is in `ABORTED` or `FAILED` state.
>
> src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 235:
> 
>> 233:         @Override
>> 234:         public void executionFinished(TestIdentifier identifier, TestExecutionResult result) {
>> 235:             /* if (identifier.isTest()) */ {
> 
> Remove commented out code, and maybe the remaining curly braces?

My idea was to keep indentation changes minimal.

-------------

PR: https://git.openjdk.org/jtreg/pull/147


More information about the jtreg-dev mailing list