RFR: 7903373: Add ability to customize test execution using main wrapper plugin [v11]

Jonathan Gibbons jjg at openjdk.org
Mon Feb 13 23:40:29 UTC 2023


On Sun, 29 Jan 2023 22:05:56 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The fix adds support of a plugin that customizes test execution.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added new file.

src/share/classes/com/sun/javatest/regtest/agent/TestThreadFactory.java line 39:

> 37: /**
> 38:  * {@code TestThreadFactory} allows some customization of test execution.
> 39:  * The jtreg creates new thread for each test using {@code new Thread(ThreadGroup tg, Runnable task);}.

Recommend: ~The~ `jtreg creates a new thread`

src/share/classes/com/sun/javatest/regtest/tool/i18n.properties line 176:

> 174: help.main.ttf.arg=<classname>
> 175: help.main.ttf.desc=Specifies the class to create thread factory for test execution. \
> 176:     The class should implement spcifig interface.

Typo: `spcifig` ?

src/share/classes/com/sun/javatest/regtest/tool/i18n.properties line 178:

> 176:     The class should implement spcifig interface.
> 177: help.main.ttfp.arg=<path>
> 178: help.main.ttfp.desc=Specifies classspath with custom test thread factory implementation. \

Suggest: replace `with` by `for`

test/docs.gmk line 33:

> 31: 
> 32: #INITIAL_TESTS += \
> 33: #	$(BUILDTESTDIR)/tidy-docs.ok

Why is this commented out?  That seems unrelated.

-------------

PR: https://git.openjdk.org/jtreg/pull/136


More information about the jtreg-dev mailing list