RFR: 7903373: Add ability to customize test execution using main wrapper plugin [v11]

Jonathan Gibbons jjg at openjdk.org
Tue Feb 14 00:09:24 UTC 2023


On Mon, 13 Feb 2023 23:27:26 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added new file.
>
> src/share/classes/com/sun/javatest/regtest/agent/TestThreadFactory.java line 39:
> 
>> 37: /**
>> 38:  * {@code TestThreadFactory} allows some customization of test execution.
>> 39:  * The jtreg creates new thread for each test using {@code new Thread(ThreadGroup tg, Runnable task);}.
> 
> Recommend: ~The~ `jtreg creates a new thread`

The name is substantially better than before (it used to be `CustomMainWrapper`).

Now, the name is annoyingly ambiguous.   It can be read as `Test` (imperative verb) `Thread-Factory` (noun) or `Test-Thread` (adjective) `Factory` (noun). (I believe it is the latter that is intended.)

I can't think of a better name, and I don't want to suggest we should go through another name change again!
For now, I think it may be enough to add a new explanatory sentence at the beginning of the doc comment,
and/or work on the rest of the comment text.

A factory for threads used to run tests.

-------------

PR: https://git.openjdk.org/jtreg/pull/136


More information about the jtreg-dev mailing list