RFR: 7903373: Add ability to customize test execution using main wrapper plugin [v5]
Leonid Mesnik
lmesnik at openjdk.org
Wed Jan 25 20:00:17 UTC 2023
On Tue, 6 Dec 2022 23:29:41 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>>
>> empty lines removed.
>
> src/share/classes/com/sun/javatest/regtest/agent/CustomMainWrapper.java line 61:
>
>> 59: Constructor<? extends CustomMainWrapper> ctor = clz.getDeclaredConstructor();
>> 60: CustomMainWrapper wrapper = ctor.newInstance();
>> 61: wrapper.setAction(actionName);
>
> Is the `actionName` ever going to be useful? Di you use it in the Loom implementation? Why would the thread created by `createThread` depend on the difference between `main` and `driver` actions?
>
> (In general, a `driver` action is handled much earlier in the execution, when `RegressionScript` decides what VM options (if any) should be used for the agent.
I re-checked, seems actionName might be not needed. We could use virtual threads in all actions. So I removed actionName.
-------------
PR: https://git.openjdk.org/jtreg/pull/136
More information about the jtreg-dev
mailing list