RFR: 7903373: Add ability to customize test execution using main wrapper plugin [v5]

Leonid Mesnik lmesnik at openjdk.org
Wed Jan 25 20:04:25 UTC 2023


On Tue, 6 Dec 2022 22:17:36 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   empty lines removed.
>
> src/share/classes/com/sun/javatest/regtest/agent/CustomMainWrapper.java line 70:
> 
>> 68:     /**
>> 69:      * This method should be implemented to run test task.
>> 70:      * Default jtreg implementation is return new Thread(tg, task);
> 
> This line, about the default jtreg implementation, is confusing, because the default jtreg behavior is not an implementation of this class or method.

I removed this line. The overall CustomMainWrapper documentation should be enough.

> src/share/classes/com/sun/javatest/regtest/agent/CustomMainWrapper.java line 80:
> 
>> 78:      * @param actionName name of action
>> 79:      */
>> 80:     default void setAction(String actionName) {
> 
> The comment says "get information" but the method name is "setAction". What am I missing?

The method is removed.

-------------

PR: https://git.openjdk.org/jtreg/pull/136


More information about the jtreg-dev mailing list