RFR: 7902485 Timeout refired %s times message confusing

Christian Stein cstein at openjdk.org
Thu Jun 15 09:41:28 UTC 2023


On Thu, 15 Jun 2023 09:21:45 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Please review this trivial patch that fixes the timeout messages printed by JTReg.
> 
> The messages were accidentally inverted by https://github.com/openjdk/jtreg/commit/b48573b504e9811ad3e6ced443b716446a7078e2#diff-8e1b55f85f319daa1e294289b63951c18cc3ba76247e59e15a37a3c9b772d543. This PR restores them to their proper positions.

Marked as reviewed by cstein (Committer).

src/share/classes/com/sun/javatest/regtest/agent/Alarm.java line 148:

> 146:                 msgOut.println(String.format("Timeout signalled after %d seconds", TimeUnit.SECONDS.convert(delay, delayUnit)));
> 147:             } else if (count % 100 == 0) {
> 148:                 msgOut.println(String.format("Timeout refired %s times", count));

`%s` could be turned into a `%d` here, as `count` is of type `int`.

-------------

PR Review: https://git.openjdk.org/jtreg/pull/158#pullrequestreview-1481147544
PR Review Comment: https://git.openjdk.org/jtreg/pull/158#discussion_r1230739257


More information about the jtreg-dev mailing list