RFR: 7902485 Timeout refired %s times message confusing [v2]

Daniel Jeliński djelinski at openjdk.org
Fri Jun 16 10:27:28 UTC 2023


On Thu, 15 Jun 2023 09:38:53 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use %d
>
> src/share/classes/com/sun/javatest/regtest/agent/Alarm.java line 148:
> 
>> 146:                 msgOut.println(String.format("Timeout signalled after %d seconds", TimeUnit.SECONDS.convert(delay, delayUnit)));
>> 147:             } else if (count % 100 == 0) {
>> 148:                 msgOut.println(String.format("Timeout refired %s times", count));
> 
> `%s` could be turned into a `%d` here, as `count` is of type `int`.

done

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/158#discussion_r1232070422


More information about the jtreg-dev mailing list