RFR: 7903500: Add Gradle Wrapper Validation workflow to jtreg
Kevin Rushforth
kcr at openjdk.org
Fri Jun 23 15:48:27 UTC 2023
On Tue, 20 Jun 2023 14:43:52 GMT, Christian Stein <cstein at openjdk.org> wrote:
> This change adds a workflow to this repository to verify that any and all `gradle-wrapper.jar` files in the repository match the SHA-256 checksums of any of our official releases. See details at https://github.com/marketplace/actions/gradle-wrapper-validation
Looks good except for a comment I left about the "on" step.
.github/workflows/gradle-wrapper-validation.yml line 2:
> 1: name: 'Validate Gradle Wrapper'
> 2: on: [push, pull_request]
The on `pull_request` will be ineffective, since this only ever runs in the context of a contributor's personal fork. Also, you will want to exclude the master branch and any pr branches, as is done in [test.yml](https://github.com/openjdk/jtreg/blob/master/.github/workflows/test.yml#L3C1-L8C1), to avoid unnecessary test runs.
-------------
PR Review: https://git.openjdk.org/jtreg/pull/159#pullrequestreview-1495388295
PR Review Comment: https://git.openjdk.org/jtreg/pull/159#discussion_r1239970705
More information about the jtreg-dev
mailing list