RFR: 7903500: Add Gradle Wrapper Validation workflow to jtreg [v2]
Christian Stein
cstein at openjdk.org
Fri Jun 23 16:01:52 UTC 2023
On Fri, 23 Jun 2023 15:40:57 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update gradle-wrapper-validation.yml
>>
>> Fine-tune event triggers
>
> .github/workflows/gradle-wrapper-validation.yml line 2:
>
>> 1: name: 'Validate Gradle Wrapper'
>> 2: on: [push, pull_request]
>
> The on `pull_request` will be ineffective, since this only ever runs in the context of a contributor's personal fork. Also, you will want to exclude the master branch and any pr branches, as is done in [test.yml](https://github.com/openjdk/jtreg/blob/master/.github/workflows/test.yml#L3C1-L8C1), to avoid unnecessary test runs.
Good points, @kevinrushforth - updating the workflow configuration accordingly.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/159#discussion_r1239987684
More information about the jtreg-dev
mailing list