RFR: CODETOOLS-7903400: DEFAULT_UNIX_ENV_VARS needs to be updated [v2]

Alexander Zvegintsev azvegint at openjdk.org
Tue May 2 11:21:38 UTC 2023


On Mon, 1 May 2023 18:41:39 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a small change to add additional environment variables that may be required on some Unix-like platforms.
>> 
>> The additions include:
>> * `DBUS_SESSION_BUS_ADDRESS`
>> * `WAYLAND_DISPLAY`
>> * all `XDG_*` variables
>> 
>> There is some related additional cleanup in this area as well.
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review feedback

src/share/classes/com/sun/javatest/regtest/tool/Tool.java line 2343:

> 2341:     private static final String[] DEFAULT_UNIX_ENV_VARS = {
> 2342:             "DBUS_SESSION_BUS_ADDRESS", "DESKTOP_SESSION", "DISPLAY",
> 2343:             "GDM_SESSION", "GNOME_DESKTOP_SESSION_ID", "GNOME_SHELL_SESSION_MODE",

Name should be `GDMSESSION`, not `GDM_SESSION`

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/152#discussion_r1182412934


More information about the jtreg-dev mailing list