RFR: CODETOOLS-7903400: DEFAULT_UNIX_ENV_VARS needs to be updated [v2]

Phil Race prr at openjdk.org
Tue May 2 16:45:47 UTC 2023


On Tue, 2 May 2023 11:16:58 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review feedback
>
> src/share/classes/com/sun/javatest/regtest/tool/Tool.java line 2343:
> 
>> 2341:     private static final String[] DEFAULT_UNIX_ENV_VARS = {
>> 2342:             "DBUS_SESSION_BUS_ADDRESS", "DESKTOP_SESSION", "DISPLAY",
>> 2343:             "GDM_SESSION", "GNOME_DESKTOP_SESSION_ID", "GNOME_SHELL_SESSION_MODE",
> 
> Name should be `GDMSESSION`, not `GDM_SESSION`

Confirmed. GDMSESSION is what is in the bug report and what my gnome desktop reports.
Otherwise LGTM.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/152#discussion_r1182795456


More information about the jtreg-dev mailing list