RFR: 7903883: --verify-exclude test existence and format checks are broken [v2]

[Jaikiran Pai]

On Fri, 15 Nov 2024 09:20:39 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:

>> The way this feature selected "the full set of tests" was actually getting "the set of tests to be run". But often, we run some subset through either specifying test files, folders, or groups. Our problemlist files will still have entries for other tests we were not running right now.
>> 
>> As a solution, --verify-exclude needs to compute the maximal set of tests that could be run for all test suites that any of the tests being run are a part of. I've implemented this by creating a dummy testmanager and passing no parameters to it.
>> 
>> Additionally, the regex for problemlist format had a typo.
>
> Ludvig Janiuk has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - verbose output
>  - rm todo

I don't have prior knowledge of this code, but reading through what's stated in the linked JBS issue and a brief look at this code, this change appears reasonable to me.

Please generate a jtreg build with this change and use it against the JDK mainline repo once, to make sure this works as expected and doesn't cause any unforeseen failures.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jtreg/pull/236#pullrequestreview-2506224638