RFR: 7903883: --verify-exclude test existence and format checks are broken [v2]
Jaikiran Pai
jpai at openjdk.org
Mon Dec 16 13:47:52 UTC 2024
On Fri, 15 Nov 2024 09:20:39 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:
>> The way this feature selected "the full set of tests" was actually getting "the set of tests to be run". But often, we run some subset through either specifying test files, folders, or groups. Our problemlist files will still have entries for other tests we were not running right now.
>>
>> As a solution, --verify-exclude needs to compute the maximal set of tests that could be run for all test suites that any of the tests being run are a part of. I've implemented this by creating a dummy testmanager and passing no parameters to it.
>>
>> Additionally, the regex for problemlist format had a typo.
>
> Ludvig Janiuk has updated the pull request incrementally with two additional commits since the last revision:
>
> - verbose output
> - rm todo
While at it, I noticed in the linked JBS issue, that the current existing error message says:
> The fully qualified test must exists.
The "exists" should have been "exist". Could you update that error message (and related self reg tests) to fix that typo? If you want to do it in a separate PR, that's fine too.
-------------
PR Comment: https://git.openjdk.org/jtreg/pull/236#issuecomment-2545672134
More information about the jtreg-dev
mailing list